GOMODULES
/
pgx
mirror of https://github.com/jackc/pgx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix text format array decoding with a string of "NULL" 

It was incorrectly being treated as NULL instead of 'NULL'.

fixes https://github.com/jackc/pgx/issues/1494
pull/1504/head
Jack Christensen 2023-02-10 19:59:03 -06:00
parent b707faea8f
commit 1f43e2e490
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pgtype/array_codec.go
View File

@ -303,7 +303,7 @@ func (c *ArrayCodec) decodeText(m *Map, arrayOID uint32, src []byte, array Array
for i, s := range uta.Elements { for i, s := range uta.Elements {
elem := array.ScanIndex(i) elem := array.ScanIndex(i)
var elemSrc []byte var elemSrc []byte
if s != "NULL" { if s != "NULL" || uta.Quoted[i] {
elemSrc = []byte(s) elemSrc = []byte(s)
} }

24
pgtype/array_codec_test.go
View File

@ -318,3 +318,27 @@ func TestArrayCodecEncodeMultipleDimensionsRagged(t *testing.T) {
defer rows.Close() defer rows.Close()
}) })
} }
// https://github.com/jackc/pgx/issues/1494
func TestArrayCodecDecodeTextArrayWithTextOfNULL(t *testing.T) {
defaultConnTestRunner.RunTest(context.Background(), t, func(ctx context.Context, t testing.TB, conn *pgx.Conn) {
{
var actual []string
err := conn.QueryRow(ctx, `select '{"foo", "NULL", " NULL "}'::text[]`).Scan(&actual)
require.NoError(t, err)
require.Equal(t, []string{"foo", "NULL", " NULL "}, actual)
}
{
var actual []pgtype.Text
err := conn.QueryRow(ctx, `select '{"foo", "NULL", NULL, " NULL "}'::text[]`).Scan(&actual)
require.NoError(t, err)
require.Equal(t, []pgtype.Text{
{String: "foo", Valid: true},
{String: "NULL", Valid: true},
{},
{String: " NULL ", Valid: true},
}, actual)
}
})
}