GOMODULES
/
pgx
mirror of https://github.com/jackc/pgx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Now throwing errors on uint32/uint64 possible data loss

pull/121/head
Nick K 2016-03-11 11:52:21 +03:00
parent e40f08e107
commit 0ea1a5245c
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
values.go
View File

@ -687,25 +687,35 @@ func Decode(vr *ValueReader, d interface{}) error {
case *int32:
*v = decodeInt4(vr)
case *uint32:
var valInt int32
switch vr.Type().DataType {
case Int2Oid:
*v = uint32(decodeInt2(vr))
valInt = int32(decodeInt2(vr))
case Int4Oid:
*v = uint32(decodeInt4(vr))
valInt = decodeInt4(vr)
default:
return fmt.Errorf("Can't convert OID %v to uint32", vr.Type().DataType)
}
if valInt < 0 {
return fmt.Errorf("%d is less than zero for uint32", valInt)
}
*v = uint32(valInt)
case *uint64:
var valInt int64
switch vr.Type().DataType {
case Int2Oid:
*v = uint64(decodeInt2(vr))
valInt = int64(decodeInt2(vr))
case Int4Oid:
*v = uint64(decodeInt4(vr))
valInt = int64(decodeInt4(vr))
case Int8Oid:
*v = uint64(decodeInt8(vr))
valInt = decodeInt8(vr)
default:
return fmt.Errorf("Can't convert OID %v to uint64", vr.Type().DataType)
}
if valInt < 0 {
return fmt.Errorf("%d is less than zero for uint32", valInt)
}
*v = uint64(valInt)
case *Oid:
*v = decodeOid(vr)
case *string: