From 0bc891e7802a3f5b958a8e961d2be50c32a9018c Mon Sep 17 00:00:00 2001 From: Iurii Krasnoshchok Date: Wed, 20 Dec 2017 14:47:52 +0100 Subject: [PATCH] Return error on unknown oid while decoding record instead of panic --- pgtype/record.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pgtype/record.go b/pgtype/record.go index 26411af2..aeca1c54 100644 --- a/pgtype/record.go +++ b/pgtype/record.go @@ -98,9 +98,10 @@ func (dst *Record) DecodeBinary(ci *ConnInfo, src []byte) error { var binaryDecoder BinaryDecoder if dt, ok := ci.DataTypeForOID(fieldOID); ok { - if binaryDecoder, ok = dt.Value.(BinaryDecoder); !ok { - return errors.Errorf("unknown oid while decoding record: %v", fieldOID) - } + binaryDecoder, _ = dt.Value.(BinaryDecoder) + } + if binaryDecoder == nil { + return errors.Errorf("unknown oid while decoding record: %v", fieldOID) } var fieldBytes []byte