GOMODULES/pgx
1
0
Fork 0
mirror of https://github.com/jackc/pgx.git synced 2025-04-27 21:25:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Start pgxpool background health check after initial connections

Browse Source 
Otherwise the health check and the create initial connection(s) may both
create connections. While this generally wouldn't be a real problem it
did cause TestPoolBackgroundChecksMinConns to flicker on CI.
This commit is contained in:
Jack Christensen 2021-11-20 11:19:10 -06:00
parent a55e88ee48
commit 058f346079
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pgxpool/pool.go
View File

@ -222,8 +222,6 @@ func ConnectConfig(ctx context.Context, config *Config) (*Pool, error) {
config.MaxConns, config.MaxConns,
) )
go p.backgroundHealthCheck()
if !config.LazyConnect { if !config.LazyConnect {
if err := p.createIdleResources(ctx, int(p.minConns)); err != nil { if err := p.createIdleResources(ctx, int(p.minConns)); err != nil {
// Couldn't create resources for minpool size. Close unhealthy pool. // Couldn't create resources for minpool size. Close unhealthy pool.
@ -240,6 +238,8 @@ func ConnectConfig(ctx context.Context, config *Config) (*Pool, error) {
res.Release() res.Release()
} }
go p.backgroundHealthCheck()
return p, nil return p, nil
} }