mirror of https://github.com/VinGarcia/ksql.git
Fix problem on the Querying benchmark for `sql`
By mistake (I forgot to delete a letter) I was calling `sqlx.Open()` instead of `sql.Open()`, which invalidates the benchmark. This is now fixed.pull/13/head
parent
83f0ce5369
commit
a5e71303cb
|
@ -326,7 +326,7 @@ func BenchmarkQuery(b *testing.B) {
|
|||
})
|
||||
|
||||
b.Run("sql", func(b *testing.B) {
|
||||
sqlDB, err := sqlx.Open(driver, connStr)
|
||||
sqlDB, err := sql.Open(driver, connStr)
|
||||
if err != nil {
|
||||
b.Fatalf("error creating sql client: %s", err)
|
||||
}
|
||||
|
@ -366,7 +366,7 @@ func BenchmarkQuery(b *testing.B) {
|
|||
b.Run("multiple-rows", func(b *testing.B) {
|
||||
for i := 0; i < b.N; i++ {
|
||||
var users []User
|
||||
rows, err := sqlDB.Queryx(`SELECT id, name, age FROM users OFFSET $1 LIMIT 10`, i%90)
|
||||
rows, err := sqlDB.Query(`SELECT id, name, age FROM users OFFSET $1 LIMIT 10`, i%90)
|
||||
if err != nil {
|
||||
b.Fatalf("query error: %s", err.Error())
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue