GOMODULES
/
ksql
mirror of https://github.com/VinGarcia/ksql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix problem on the Querying benchmark for `sql` 

By mistake (I forgot to delete a letter) I was calling
`sqlx.Open()` instead of `sql.Open()`, which invalidates
the benchmark.

This is now fixed.
pull/13/head
Vinícius Garcia 2021-11-16 19:51:14 -03:00
parent 83f0ce5369
commit a5e71303cb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
benchmarks/benchmarks_test.go
View File

@ -326,7 +326,7 @@ func BenchmarkQuery(b *testing.B) {
}) })
b.Run("sql", func(b *testing.B) { b.Run("sql", func(b *testing.B) {
sqlDB, err := sqlx.Open(driver, connStr) sqlDB, err := sql.Open(driver, connStr)
if err != nil { if err != nil {
b.Fatalf("error creating sql client: %s", err) b.Fatalf("error creating sql client: %s", err)
} }
@ -366,7 +366,7 @@ func BenchmarkQuery(b *testing.B) {
b.Run("multiple-rows", func(b *testing.B) { b.Run("multiple-rows", func(b *testing.B) {
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
var users []User var users []User
rows, err := sqlDB.Queryx(`SELECT id, name, age FROM users OFFSET $1 LIMIT 10`, i%90) rows, err := sqlDB.Query(`SELECT id, name, age FROM users OFFSET $1 LIMIT 10`, i%90)
if err != nil { if err != nil {
b.Fatalf("query error: %s", err.Error()) b.Fatalf("query error: %s", err.Error())
} }