From 749466d29a6cff1d9ed6fad2eb7dda4785d66a47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vin=C3=ADcius=20Garcia?= Date: Tue, 20 Dec 2022 22:46:42 -0300 Subject: [PATCH 1/2] Rename README template to lowercase so auto-complete works better --- Makefile | 4 ++-- README.template.md => readme.template.md | 0 2 files changed, 2 insertions(+), 2 deletions(-) rename README.template.md => readme.template.md (100%) diff --git a/Makefile b/Makefile index ccfcac6..b344e83 100644 --- a/Makefile +++ b/Makefile @@ -19,8 +19,8 @@ bench: go-mod-tidy @echo "Benchmark executed at: $$(date --iso)" | tee -a benchmark.tmp @echo "Benchmark executed on commit: $$(git rev-parse HEAD)" | tee -a benchmark.tmp -readme: benchmark.tmp README.template.md - go run scripts/build-readme-from-template.go README.template.md examples/crud/crud.go benchmark.tmp +readme: benchmark.tmp readme.template.md + go run scripts/build-readme-from-template.go readme.template.md examples/crud/crud.go benchmark.tmp lint: setup go-mod-tidy @$(GOBIN)/staticcheck $(path) $(args) diff --git a/README.template.md b/readme.template.md similarity index 100% rename from README.template.md rename to readme.template.md From 475955bb33a942f066a379b94057c7c4e9de4ec6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vin=C3=ADcius=20Garcia?= Date: Tue, 20 Dec 2022 22:49:01 -0300 Subject: [PATCH 2/2] Remove some TODO items that were not KISS After thinking about some of the TODO items I decided they were not really in the scope of KSQL and that there were good ways of doing the same things they were supposed to do without them. So I decided to remove them from the TODO list. I can change my mind again if someone informs me of a good use-case where one of those features would be really helpful instead of just a minor improvement. --- README.md | 4 ---- readme.template.md | 4 ---- 2 files changed, 8 deletions(-) diff --git a/README.md b/README.md index 14c5e63..0173252 100644 --- a/README.md +++ b/README.md @@ -462,10 +462,6 @@ is configured to kill the containers after 20 seconds. - Update `ksqltest.FillStructWith` to work with `ksql:"..,json"` tagged attributes - Create a way for users to submit user defined dialects - Improve error messages (ongoing) -- Add support for the Patch function to work with maps for partial updates -- Add support for the Insert function to work with maps -- Add support for a `ksql.Array(params ...interface{})` for allowing queries like this: - `db.Query(ctx, &user, "SELECT * FROM user WHERE id in (?)", ksql.Array(1,2,3))` ## Optimization Oportunities diff --git a/readme.template.md b/readme.template.md index f528d8f..1ddd83d 100644 --- a/readme.template.md +++ b/readme.template.md @@ -229,10 +229,6 @@ is configured to kill the containers after 20 seconds. - Update `ksqltest.FillStructWith` to work with `ksql:"..,json"` tagged attributes - Create a way for users to submit user defined dialects - Improve error messages (ongoing) -- Add support for the Patch function to work with maps for partial updates -- Add support for the Insert function to work with maps -- Add support for a `ksql.Array(params ...interface{})` for allowing queries like this: - `db.Query(ctx, &user, "SELECT * FROM user WHERE id in (?)", ksql.Array(1,2,3))` ## Optimization Oportunities