From 6f2ecbef5ab7a16708fdd29069a9a509ae5ac0f2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vin=C3=ADcius=20Garcia?= <vingarcia00@gmail.com>
Date: Tue, 28 Dec 2021 22:09:28 -0300
Subject: [PATCH] Write tests for two trivial functions for raising the test
 coverage

---
 ksql.go      | 10 +++++-----
 ksql_test.go | 31 +++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+), 5 deletions(-)

diff --git a/ksql.go b/ksql.go
index baeb9c5..b786dee 100644
--- a/ksql.go
+++ b/ksql.go
@@ -86,16 +86,16 @@ func (c *Config) SetDefaultValues() {
 // of the DBAdapter interface
 func NewWithAdapter(
 	db DBAdapter,
-	dbDriver string,
+	dialectName string,
 ) (DB, error) {
-	dialect := supportedDialects[dbDriver]
+	dialect := supportedDialects[dialectName]
 	if dialect == nil {
-		return DB{}, fmt.Errorf("unsupported driver `%s`", dbDriver)
+		return DB{}, fmt.Errorf("unsupported driver `%s`", dialectName)
 	}
 
 	return DB{
 		dialect: dialect,
-		driver:  dbDriver,
+		driver:  dialectName,
 		db:      db,
 	}, nil
 }
@@ -441,7 +441,7 @@ func (c DB) insertReturningIDs(
 	defer rows.Close()
 
 	if !rows.Next() {
-		err := fmt.Errorf("unexpected error retrieving the id columns from the database")
+		err := fmt.Errorf("unexpected error when retrieving the id columns from the database")
 		if rows.Err() != nil {
 			err = rows.Err()
 		}
diff --git a/ksql_test.go b/ksql_test.go
index 0978e22..ca42380 100644
--- a/ksql_test.go
+++ b/ksql_test.go
@@ -1896,6 +1896,37 @@ func TestScanRows(t *testing.T) {
 	})
 }
 
+func TestConfigSetDefaultValues(t *testing.T) {
+	config := Config{}
+	config.SetDefaultValues()
+
+	assert.Equal(t, config.MaxOpenConns, 1)
+}
+
+func TestNewAdapterWith(t *testing.T) {
+	t.Run("should build new instances correctly", func(t *testing.T) {
+		for dialectName := range supportedDialects {
+			db, err := NewWithAdapter(
+				DBAdapter(nil),
+				dialectName,
+			)
+
+			assert.Equal(t, nil, err)
+			assert.Equal(t, supportedDialects[dialectName], db.dialect)
+			assert.Equal(t, dialectName, db.driver)
+		}
+	})
+
+	t.Run("should report invalid dialectNames correctly", func(t *testing.T) {
+		_, err := NewWithAdapter(
+			DBAdapter(nil),
+			"fake-dialect-name",
+		)
+
+		assert.NotEqual(t, nil, err)
+	})
+}
+
 func createTables(driver string) error {
 	connStr := connectionString[driver]
 	if connStr == "" {