GOMODULES/ksql
1
0
Fork 0
mirror of https://github.com/VinGarcia/ksql.git synced 2025-05-31 11:42:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary extra argument from ksql.NewWithAdapter

Browse Source 
To be honest I don't know how it ended up there =P
This commit is contained in:
Vinícius Garcia 2021-09-27 18:58:44 -03:00
parent af4eba4bf6
commit 268e3d3c36
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ksql.go
View File

@ -34,7 +34,7 @@ type DB struct {
// from database/sql, i.e. if any struct implements the functions below // from database/sql, i.e. if any struct implements the functions below
// with the exact same semantic as the sql package it will work with ksql. // with the exact same semantic as the sql package it will work with ksql.
// //
// To create a new client using this adapter use ksql.NewWithDB() // To create a new client using this adapter use ksql.NewWithAdapter()
type DBAdapter interface { type DBAdapter interface {
ExecContext(ctx context.Context, query string, args ...interface{}) (Result, error) ExecContext(ctx context.Context, query string, args ...interface{}) (Result, error)
QueryContext(ctx context.Context, query string, args ...interface{}) (Rows, error) QueryContext(ctx context.Context, query string, args ...interface{}) (Rows, error)
@ -96,7 +96,7 @@ func New(
db.SetMaxOpenConns(config.MaxOpenConns) db.SetMaxOpenConns(config.MaxOpenConns)
return NewWithAdapter(SQLAdapter{db}, dbDriver, connectionString) return NewWithAdapter(SQLAdapter{db}, dbDriver)
} }
// NewWithPGX instantiates a new KissSQL client using the pgx // NewWithPGX instantiates a new KissSQL client using the pgx
@ -121,7 +121,7 @@ func NewWithPGX(
return DB{}, err return DB{}, err
} }
db, err = NewWithAdapter(PGXAdapter{pool}, "postgres", connectionString) db, err = NewWithAdapter(PGXAdapter{pool}, "postgres")
return db, err return db, err
} }
@ -130,7 +130,6 @@ func NewWithPGX(
func NewWithAdapter( func NewWithAdapter(
db DBAdapter, db DBAdapter,
dbDriver string, dbDriver string,
connectionString string,
) (DB, error) { ) (DB, error) {
dialect := supportedDialects[dbDriver] dialect := supportedDialects[dbDriver]
if dialect == nil { if dialect == nil {