GOMODULES
/
ksql
mirror of https://github.com/VinGarcia/ksql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #55 from mrheinen/master 

Check if a field is private after confirming it has a ksql tag
master
Vinícius Garcia 2024-11-06 18:48:56 -03:00 committed by GitHub
parent 0a95b40908 688344f710
commit 24b9313323
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/structs/structs.go
View File

@ -257,10 +257,6 @@ func getTagNames(t reflect.Type) (_ StructInfo, err error) {
byName: map[string]*FieldInfo{}, byName: map[string]*FieldInfo{},
} }
for i := 0; i < t.NumField(); i++ { for i := 0; i < t.NumField(); i++ {
// If this field is private:
if t.Field(i).PkgPath != "" {
return StructInfo{}, fmt.Errorf("all fields using the ksql tags must be exported, but %v is unexported", t)
}
attrName := t.Field(i).Name attrName := t.Field(i).Name
name := t.Field(i).Tag.Get("ksql") name := t.Field(i).Tag.Get("ksql")
@ -268,6 +264,11 @@ func getTagNames(t reflect.Type) (_ StructInfo, err error) {
continue continue
} }
// If this field is private:
if t.Field(i).PkgPath != "" {
return StructInfo{}, fmt.Errorf("all fields using the ksql tags must be exported, but %v is unexported", t)
}
tags := strings.Split(name, ",") tags := strings.Split(name, ",")
var modifier ksqlmodifiers.AttrModifier var modifier ksqlmodifiers.AttrModifier
if len(tags) > 1 { if len(tags) > 1 {