sql migration: diagnose scripts that have no Up/Down annotations. fixes #3

migration_sql.go

@@ -29,6 +29,11 @@ func runSQLMigration(db *sql.DB, script string, v int64, direction bool) error {
 		log.Fatal(err)
 	}
 
+	// track the count of each section
+	// so we can diagnose scripts with no annotations
+	upSections := 0
+	downSections := 0
+
 	// ensure we don't apply a query until we're sure it's going
 	// in the direction we're interested in
 	directionIsActive := false
@@ -43,8 +48,10 @@ func runSQLMigration(db *sql.DB, script string, v int64, direction bool) error {
 
 		if strings.HasPrefix(query, "-- +goose Up") {
 			directionIsActive = direction == true
+			upSections++
 		} else if strings.HasPrefix(query, "-- +goose Down") {
 			directionIsActive = direction == false
+			downSections++
 		}
 
 		if !directionIsActive || query == "" {
@@ -62,6 +69,12 @@ func runSQLMigration(db *sql.DB, script string, v int64, direction bool) error {
 		log.Fatalf("error finalizing migration %s, quitting. (%v)", filepath.Base(script), err)
 	}
 
+	if upSections == 0 && downSections == 0 {
+		log.Printf(`WARNING: no Up/Down annotations found in %s, so no statements were executed.
+			See https://bitbucket.org/liamstask/goose/overview for details.`,
+			filepath.Base(script))
+	}
+
 	return nil
 }