automatically set TLS config value to DSN when using TLS on mysql

cmd/goose/driver_mysql.go

@@ -17,10 +17,10 @@ import (
 // the parameter `parseTime` set to true. This allows internal goose logic
 // to assume that DATETIME/DATE/TIMESTAMP can be scanned into the time.Time
 // type.
-func normalizeDBString(driver string, str string) string {
+func normalizeDBString(driver string, str string, tls bool) string {
 	if driver == "mysql" {
 		var err error
-		str, err = normalizeMySQLDSN(str)
+		str, err = normalizeMySQLDSN(str, tls)
 		if err != nil {
 			log.Fatalf("failed to normalize MySQL connection string: %v", err)
 		}
@@ -28,17 +28,20 @@ func normalizeDBString(driver string, str string) string {
 	return str
 }
 
-func normalizeMySQLDSN(dsn string) (string, error) {
+const tlsConfigKey = "custom"
+
+func normalizeMySQLDSN(dsn string, tls bool) (string, error) {
 	config, err := mysql.ParseDSN(dsn)
 	if err != nil {
 		return "", err
 	}
 	config.ParseTime = true
+	if tls {
+		config.TLSConfig = tlsConfigKey
+	}
 	return config.FormatDSN(), nil
 }
 
-const tlsConfigKey = "custom"
-
 func registerTLSConfig(pemfile string) error {
 	rootCertPool := x509.NewCertPool()
 	pem, err := ioutil.ReadFile(pemfile)

cmd/goose/driver_no_mysql.go

@@ -7,7 +7,7 @@ import (
 	_ "github.com/ziutek/mymysql/godrv"
 )
 
-func normalizeDBString(driver string, str string) string {
+func normalizeDBString(driver string, str string, tls bool) string {
 	return str
 }
 

cmd/goose/main.go

@@ -36,7 +36,8 @@ func main() {
 		return
 	}
 
-	if *sslCA != "" {
+	tls := *sslCA != ""
+	if tls {
 		if err := registerTLSConfig(*sslCA); err != nil {
 			log.Fatalf("goose run: %v", err)
 		}
@@ -62,7 +63,7 @@ func main() {
 
 	driver, dbstring, command := args[0], args[1], args[2]
 
-	db, err := goose.OpenDBWithDriver(driver, normalizeDBString(driver, dbstring))
+	db, err := goose.OpenDBWithDriver(driver, normalizeDBString(driver, dbstring, tls))
 	if err != nil {
 		log.Fatalf("-dbstring=%q: %v\n", dbstring, err)
 	}