From 33487e40af7ae91cca46cef1f80bfb63c392e909 Mon Sep 17 00:00:00 2001 From: Zeal Wierslee Date: Fri, 29 Apr 2022 10:22:52 -0400 Subject: [PATCH] Make NumericComponent errors more understandable (#334) --- migrate.go | 4 ++-- migration.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migrate.go b/migrate.go index 5d90dfd..3986746 100644 --- a/migrate.go +++ b/migrate.go @@ -156,7 +156,7 @@ func collectMigrationsFS(fsys fs.FS, dirpath string, current, target int64) (Mig for _, file := range sqlMigrationFiles { v, err := NumericComponent(file) if err != nil { - return nil, err + return nil, fmt.Errorf("could not parse SQL migration file %q: %w", file, err) } if versionFilter(v, current, target) { migration := &Migration{Version: v, Next: -1, Previous: -1, Source: file} @@ -168,7 +168,7 @@ func collectMigrationsFS(fsys fs.FS, dirpath string, current, target int64) (Mig for _, migration := range registeredGoMigrations { v, err := NumericComponent(migration.Source) if err != nil { - return nil, err + return nil, fmt.Errorf("could not parse go migration file %q: %w", migration.Source, err) } if versionFilter(v, current, target) { migrations = append(migrations, migration) diff --git a/migration.go b/migration.go index 267006b..9ceb76d 100644 --- a/migration.go +++ b/migration.go @@ -137,7 +137,7 @@ func NumericComponent(name string) (int64, error) { idx := strings.Index(base, "_") if idx < 0 { - return 0, errors.New("no separator found") + return 0, errors.New("no filename separator '_' found") } n, e := strconv.ParseInt(base[:idx], 10, 64)