GOMODULES
/
goose
mirror of https://github.com/pressly/goose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix goose memory consumption on large migrations

pull/93/head
Max Chechel 2018-01-22 19:51:45 +03:00
parent b0454a40a9
commit 111f7d20fe
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
migration_sql.go
View File

@ -8,9 +8,17 @@ import (
"log" "log"
"os" "os"
"strings" "strings"
"sync"
) )
const sqlCmdPrefix = "-- +goose " const sqlCmdPrefix = "-- +goose "
const scanBufSize = 4 * 1024 * 1024
var bufferPool = sync.Pool{
New: func() interface{} {
return make([]byte, scanBufSize)
},
}
// Checks the line to see if the line has a statement-ending semicolon // Checks the line to see if the line has a statement-ending semicolon
// or if the line contains a double-dash comment. // or if the line contains a double-dash comment.
@ -18,6 +26,7 @@ func endsWithSemicolon(line string) bool {
prev := "" prev := ""
scanner := bufio.NewScanner(strings.NewReader(line)) scanner := bufio.NewScanner(strings.NewReader(line))
scanner.Buffer(bufferPool.Get().([]byte), scanBufSize)
scanner.Split(bufio.ScanWords) scanner.Split(bufio.ScanWords)
for scanner.Scan() { for scanner.Scan() {
@ -43,6 +52,7 @@ func endsWithSemicolon(line string) bool {
func getSQLStatements(r io.Reader, direction bool) (stmts []string, tx bool) { func getSQLStatements(r io.Reader, direction bool) (stmts []string, tx bool) {
var buf bytes.Buffer var buf bytes.Buffer
scanner := bufio.NewScanner(r) scanner := bufio.NewScanner(r)
scanner.Buffer(bufferPool.Get().([]byte), scanBufSize)
// track the count of each section // track the count of each section
// so we can diagnose scripts with no annotations // so we can diagnose scripts with no annotations