Commit Graph

22 Commits (208788de28150f1ceba5fbfa2f3fc5f191ac3258)

Author SHA1 Message Date
Dustin Oprea 9743a98845 Revert "Revert "Report-card fixes""
This reverts commit 4450f89e048a2373cd82a911725b6c54d22632eb.

The next commit has the fixes.
2020-06-12 02:13:36 -04:00
Dustin Oprea 591504aef0 Revert "Report-card fixes"
This reverts commit eb5bd13c98.

Introduced some new issues, here. This is being debugged on a separate
branch.

Fixes #41
2020-06-12 01:52:09 -04:00
Dustin Oprea eb5bd13c98 Report-card fixes 2020-06-10 16:11:13 -04:00
Dustin Oprea 08ac8466dd ifd.go: Add type system for IFD IDs, names, and paths
This allows us to pass around individual tokens that we can use to
generate IDs, names, and qualified and non-qualified IFD paths, rather
than [necessarily] having to pass or store them individually.

The previous global variables were strings. Now they are IfdIdentity structs
and have been renamed to be more accurate (in general, as well as for this).
The previous variables have been kept but are now just assigned to the newer
variables. This is backwards-compatibility that will be removed in the future.
2020-05-20 14:07:16 -04:00
Dustin Oprea cc316fb440 ifd_enumerate.go: (*Ifd).PrintTagTree() no longer fails on parseable undefined values
https://github.com/dsoprea/go-exif/issues/33
2020-05-02 17:11:50 -04:00
Dustin Oprea 80e3b12b98 undefined/exif_9286_user_comment.go: Validate for minimum user-notes size 2020-05-02 16:24:00 -04:00
Dustin Oprea 45986dbda3 Now a specific error for unparseable undefined tags 2020-05-02 16:23:19 -04:00
Dustin Oprea 90b66e3d11 Renamed V2 constant
From ErrUnhandledUnknownTypedTag to ErrUnhandledUndefinedTypedTag. The
release just happened. There should be minimal fallout.
2020-01-13 13:44:00 -05:00
Dustin Oprea 106cad7062 Add tests for remaining undefined types
- Also fixed a typeo in several recopied error messages.
2020-01-12 18:56:35 -05:00
Dustin Oprea 25524615d1 Fix for type-embedded strings not being encoded to JSON correctly in earlier Go's 2020-01-12 18:56:35 -05:00
Dustin Oprea 41fd3ae870 undefined: Add five test suites 2020-01-12 18:56:35 -05:00
Dustin Oprea a52d1de840 undefined: Add three suites of tests 2020-01-12 18:56:35 -05:00
Dustin Oprea 4fd78f1397 README.md: Tweaked comment regarding undefined-value 0xa40b 2020-01-12 18:56:35 -05:00
Dustin Oprea fa4e784620 ifd_tag_entry.go: Renamed unexported getter to be nicer 2020-01-12 18:56:35 -05:00
Dustin Oprea 7d26e69f8d Add tested for undefined-tag types 2020-01-12 18:56:35 -05:00
Dustin Oprea e7e1e89ffb undefined/accessor.go: Drop unnecessary parameters from Decode() 2020-01-12 18:56:35 -05:00
Dustin Oprea 351f1b7549 undefined/type.go: Formalized requirement for undefined-types being Stringers 2020-01-12 18:56:35 -05:00
Dustin Oprea 9a4bd45d39 undefined/type.go: Drop TagUndefinedType_UnknownValue
Not used anywhere
2020-01-12 18:56:35 -05:00
Dustin Oprea d293fcac9c undefined/exif_8828_oecf.go: Add Encode() 2020-01-12 18:56:35 -05:00
Dustin Oprea 32a5d88770 New integration of common/ and undefined/ subpackages
- common/type.go: Add FormatFromType() .
- Renamed common/type_encode.go to common/value_encoder.go .
2020-01-12 18:56:35 -05:00
Dustin Oprea 5c7dc45079 Added all tests for type.go, type_encode.go, parser.go, value_context.go, and utility.go
- Add .MODULE_ROOT anchor file to support testing.
2020-01-12 18:56:35 -05:00
Dustin Oprea bf3bc4e542 Refactor undefined-type tag processing 2020-01-12 18:56:35 -05:00