GOMODULES/go-exif
1
0
Fork 0
mirror of https://github.com/dsoprea/go-exif.git synced 2025-05-08 00:19:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

ifd_enumerate: Bugfix for incorrect read semantics.

Browse Source 
- ...to make sure we get the right number of bytes.
This commit is contained in:
Dustin Oprea 2018-09-16 03:42:48 -04:00
parent 811286316f
commit ab09051aaa
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ifd_enumerate.go
View File

@ -57,11 +57,17 @@ func (ife *IfdTagEnumerator) getUint16() (value uint16, raw []byte, err error) {
} }
}() }()
raw = make([]byte, 2) needBytes := 2
offset := 0
raw = make([]byte, needBytes)
_, err = ife.buffer.Read(raw) for offset < needBytes {
n, err := ife.buffer.Read(raw[offset:])
log.PanicIf(err) log.PanicIf(err)
offset += n
}
if ife.byteOrder == binary.BigEndian { if ife.byteOrder == binary.BigEndian {
value = binary.BigEndian.Uint16(raw) value = binary.BigEndian.Uint16(raw)
} else { } else {
@ -81,11 +87,17 @@ func (ife *IfdTagEnumerator) getUint32() (value uint32, raw []byte, err error) {
} }
}() }()
raw = make([]byte, 4) needBytes := 4
offset := 0
raw = make([]byte, needBytes)
_, err = ife.buffer.Read(raw) for offset < needBytes {
n, err := ife.buffer.Read(raw[offset:])
log.PanicIf(err) log.PanicIf(err)
offset += n
}
if ife.byteOrder == binary.BigEndian { if ife.byteOrder == binary.BigEndian {
value = binary.BigEndian.Uint32(raw) value = binary.BigEndian.Uint32(raw)
} else { } else {