GOMODULES
/
go-exif
mirror of https://github.com/dsoprea/go-exif.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

type_decode: Switch unknown-type processor to read as ACII-non-nul. 

- This is the type that we're officially using so this is how we should
  be parsing it.
pull/3/head
Dustin Oprea 2018-04-25 15:14:33 -04:00
parent 395c67bd57
commit a23c437e5e
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ifd_builder_encode_test.go
View File

@ -309,5 +309,3 @@ func Test_IfdByteEncoder_encodeTagToBytes_bytes_allocated(t *testing.T) {
// TODO(dustin): !! Test specific unknown-type tags.
// TODO(dustin): !! Test what happens with unhandled unknown-type tags (though it should never get to this point in the normal workflow).
// TODO(dustin): !! Test child IFDs (may not be possible until after writing tests for higher-level IB encode).

10
type_decode.go
View File

@ -612,7 +612,7 @@ func UndefinedValue(indexedIfdName string, tagId uint16, valueContext ValueConte
tt := NewTagType(TypeAsciiNoNul, byteOrder)
valueString, err := tt.ReadAsciiValue(valueContext)
valueString, err := tt.ReadAsciiNoNulValue(valueContext)
log.PanicIf(err)
return TagUnknownType_GeneralString(valueString), nil
@ -621,7 +621,7 @@ func UndefinedValue(indexedIfdName string, tagId uint16, valueContext ValueConte
tt := NewTagType(TypeAsciiNoNul, byteOrder)
valueString, err := tt.ReadAsciiValue(valueContext)
valueString, err := tt.ReadAsciiNoNulValue(valueContext)
log.PanicIf(err)
return TagUnknownType_GeneralString(valueString), nil
@ -722,7 +722,7 @@ func UndefinedValue(indexedIfdName string, tagId uint16, valueContext ValueConte
tt := NewTagType(TypeAsciiNoNul, byteOrder)
valueString, err := tt.ReadAsciiValue(valueContext)
valueString, err := tt.ReadAsciiNoNulValue(valueContext)
log.PanicIf(err)
return TagUnknownType_GeneralString(valueString), nil
@ -731,7 +731,7 @@ func UndefinedValue(indexedIfdName string, tagId uint16, valueContext ValueConte
tt := NewTagType(TypeAsciiNoNul, byteOrder)
valueString, err := tt.ReadAsciiValue(valueContext)
valueString, err := tt.ReadAsciiNoNulValue(valueContext)
log.PanicIf(err)
return TagUnknownType_GeneralString(valueString), nil
@ -742,7 +742,7 @@ func UndefinedValue(indexedIfdName string, tagId uint16, valueContext ValueConte
tt := NewTagType(TypeAsciiNoNul, byteOrder)
valueString, err := tt.ReadAsciiValue(valueContext)
valueString, err := tt.ReadAsciiNoNulValue(valueContext)
log.PanicIf(err)
return TagUnknownType_GeneralString(valueString), nil