GOMODULES
/
go-exif
mirror of https://github.com/dsoprea/go-exif.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

type_encode.go: Add redundancy comments

for/master
Dustin Oprea 2020-01-01 23:58:06 -05:00
parent 3a4fc51e30
commit 1ae6e31ca9
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
type_encode.go
View File

@ -17,6 +17,8 @@ var (
type EncodedData struct { type EncodedData struct {
Type TagTypePrimitive Type TagTypePrimitive
Encoded []byte Encoded []byte
// TODO(dustin): Is this really necessary? We might have this just to correlate to the incoming stream format (raw bytes and a unit-count both for incoming and outgoing).
UnitCount uint32 UnitCount uint32
} }
@ -185,6 +187,8 @@ func (ve *ValueEncoder) Encode(value interface{}) (ed EncodedData, err error) {
} }
}() }()
// TODO(dustin): This is redundant with EncodeWithType. Refactor one to use the other.
switch value.(type) { switch value.(type) {
case []byte: case []byte:
ed, err = ve.encodeBytes(value.([]byte)) ed, err = ve.encodeBytes(value.([]byte))
@ -223,6 +227,8 @@ func (ve *ValueEncoder) EncodeWithType(tt TagType, value interface{}) (ed Encode
} }
}() }()
// TODO(dustin): This is redundant with Encode. Refactor one to use the other.
switch tt.Type() { switch tt.Type() {
case TypeByte: case TypeByte:
ed, err = ve.encodeBytes(value.([]byte)) ed, err = ve.encodeBytes(value.([]byte))