mirror of
https://github.com/gofiber/fiber.git
synced 2025-05-17 21:21:54 +00:00
* feat!(middleware/session): re-write session middleware with handler * test(middleware/session): refactor to IdleTimeout * fix: lint errors * test: Save session after setting or deleting raw data in CSRF middleware * Update middleware/session/middleware.go Co-authored-by: Renan Bastos <renanbastos.tec@gmail.com> * fix: mutex and globals order * feat: Re-Add read lock to session Get method * feat: Migrate New() to return middleware * chore: Refactor session middleware to improve session handling * chore: Private get on store * chore: Update session middleware to use saveSession instead of save * chore: Update session middleware to use getSession instead of get * chore: Remove unused error handler in session middleware config * chore: Update session middleware to use NewWithStore in CSRF tests * test: add test * fix: destroyed session and GHSA-98j2-3j3p-fw2v * chore: Refactor session_test.go to use newStore() instead of New() * feat: Improve session middleware test coverage and error handling This commit improves the session middleware test coverage by adding assertions for the presence of the Set-Cookie header and the token value. It also enhances error handling by checking for the expected number of parts in the Set-Cookie header. * chore: fix lint issues * chore: Fix session middleware locking issue and improve error handling * test: improve middleware test coverage and error handling * test: Add idle timeout test case to session middleware test * feat: add GetSession(id string) (*Session, error) * chore: lint * docs: Update session middleware docs * docs: Security Note to examples * docs: Add recommendation for CSRF protection in session middleware * chore: markdown lint * docs: Update session middleware docs * docs: makrdown lint * test(middleware/session): Add unit tests for session config.go * test(middleware/session): Add unit tests for store.go * test(middleware/session): Add data.go unit tests * refactor(middleware/session): session tests and add session release test - Refactor session tests to improve readability and maintainability. - Add a new test case to ensure proper session release functionality. - Update session.md * refactor: session data locking in middleware/session/data.go * refactor(middleware/session): Add unit test for session middleware store * test: fix session_test.go and store_test.go unit tests * refactor(docs): Update session.md with v3 changes to Expiration * refactor(middleware/session): Improve data pool handling and locking * chore(middleware/session): TODO for Expiration field in session config * refactor(middleware/session): Improve session data pool handling and locking * refactor(middleware/session): Improve session data pool handling and locking * test(middleware/csrf): add session middleware coverage * chroe(middleware/session): TODO for unregistered session middleware * refactor(middleware/session): Update session middleware for v3 changes * refactor(middleware/session): Update session middleware for v3 changes * refactor(middleware/session): Update session middleware idle timeout - Update the default idle timeout for session middleware from 24 hours to 30 minutes. - Add a note in the session middleware documentation about the importance of the middleware order. * docws(middleware/session): Add note about IdleTimeout requiring save using legacy approach * refactor(middleware/session): Update session middleware idle timeout Update the idle timeout for the session middleware to 30 minutes. This ensures that the session expires after a period of inactivity. The previous value was 24 hours, which is too long for most use cases. This change improves the security and efficiency of the session management. * docs(middleware/session): Update session middleware idle timeout and configuration * test(middleware/session): Fix tests for updated panics * refactor(middleware/session): Update session middleware initialization and saving * refactor(middleware/session): Remove unnecessary comment about negative IdleTimeout value * refactor(middleware/session): Update session middleware make NewStore public * refactor(middleware/session): Update session middleware Set, Get, and Delete methods Refactor the Set, Get, and Delete methods in the session middleware to use more descriptive parameter names. Instead of using "middlewareContextKey", the methods now use "key" to represent the key of the session value. This improves the readability and clarity of the code. * feat(middleware/session): AbsoluteTimeout and key any * fix(middleware/session): locking issues and lint errors * chore(middleware/session): Regenerate code in data_msgp.go * refactor(middleware/session): rename GetSessionByID to GetByID This commit also includes changes to the session_test.go and store_test.go files to add test cases for the new GetByID method. * docs(middleware/session): AbsoluteTimeout * refactor(middleware/csrf): Rename Expiration to IdleTimeout * docs(whats-new): CSRF Rename Expiration to IdleTimeout and remove SessionKey field * refactor(middleware/session): Rename expirationKeyType to absExpirationKeyType and update related functions * refactor(middleware/session): rename Test_Session_Save_Absolute to Test_Session_Save_AbsoluteTimeout * chore(middleware/session): update as per PR comments * docs(middlware/session): fix indent lint * fix(middleware/session): Address EfeCtn Comments * refactor(middleware/session): Move bytesBuffer to it's own pool * test(middleware/session): add decodeSessionData error coverage * refactor(middleware/session): Update absolute timeout handling - Update absolute timeout handling in getSession function - Set absolute expiration time in getSession function - Delete expired session in GetByID function * refactor(session/middleware): fix *Session nil ctx when using Store.GetByID * refactor(middleware/session): Remove unnecessary line in session_test.go * fix(middleware/session): *Session lifecycle issues * docs(middleware/session): Update GetByID method documentation * docs(middleware/session): Update GetByID method documentation * docs(middleware/session): markdown lint * refactor(middleware/session): Simplify error handling in DefaultErrorHandler * fix( middleware/session/config.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add ctx releases for the test cases --------- Co-authored-by: Renan Bastos <renanbastos.tec@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan Calderon-Perez <835733+gaby@users.noreply.github.com> Co-authored-by: René <rene@gofiber.io>
226 lines
5.5 KiB
Go
226 lines
5.5 KiB
Go
package session
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/gofiber/fiber/v3"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/valyala/fasthttp"
|
|
)
|
|
|
|
// go test -run Test_Store_getSessionID
|
|
func Test_Store_getSessionID(t *testing.T) {
|
|
t.Parallel()
|
|
expectedID := "test-session-id"
|
|
|
|
// fiber instance
|
|
app := fiber.New()
|
|
|
|
t.Run("from cookie", func(t *testing.T) {
|
|
t.Parallel()
|
|
// session store
|
|
store := NewStore()
|
|
// fiber context
|
|
ctx := app.AcquireCtx(&fasthttp.RequestCtx{})
|
|
defer app.ReleaseCtx(ctx)
|
|
|
|
// set cookie
|
|
ctx.Request().Header.SetCookie(store.sessionName, expectedID)
|
|
|
|
require.Equal(t, expectedID, store.getSessionID(ctx))
|
|
})
|
|
|
|
t.Run("from header", func(t *testing.T) {
|
|
t.Parallel()
|
|
// session store
|
|
store := NewStore(Config{
|
|
KeyLookup: "header:session_id",
|
|
})
|
|
// fiber context
|
|
ctx := app.AcquireCtx(&fasthttp.RequestCtx{})
|
|
defer app.ReleaseCtx(ctx)
|
|
|
|
// set header
|
|
ctx.Request().Header.Set(store.sessionName, expectedID)
|
|
|
|
require.Equal(t, expectedID, store.getSessionID(ctx))
|
|
})
|
|
|
|
t.Run("from url query", func(t *testing.T) {
|
|
t.Parallel()
|
|
// session store
|
|
store := NewStore(Config{
|
|
KeyLookup: "query:session_id",
|
|
})
|
|
// fiber context
|
|
ctx := app.AcquireCtx(&fasthttp.RequestCtx{})
|
|
defer app.ReleaseCtx(ctx)
|
|
|
|
// set url parameter
|
|
ctx.Request().SetRequestURI(fmt.Sprintf("/path?%s=%s", store.sessionName, expectedID))
|
|
|
|
require.Equal(t, expectedID, store.getSessionID(ctx))
|
|
})
|
|
}
|
|
|
|
// go test -run Test_Store_Get
|
|
// Regression: https://github.com/gofiber/fiber/issues/1408
|
|
// Regression: https://github.com/gofiber/fiber/security/advisories/GHSA-98j2-3j3p-fw2v
|
|
func Test_Store_Get(t *testing.T) {
|
|
// Regression: https://github.com/gofiber/fiber/security/advisories/GHSA-98j2-3j3p-fw2v
|
|
t.Parallel()
|
|
unexpectedID := "test-session-id"
|
|
// fiber instance
|
|
app := fiber.New()
|
|
t.Run("session should be re-generated if it is invalid", func(t *testing.T) {
|
|
t.Parallel()
|
|
// session store
|
|
store := NewStore()
|
|
// fiber context
|
|
ctx := app.AcquireCtx(&fasthttp.RequestCtx{})
|
|
defer app.ReleaseCtx(ctx)
|
|
|
|
// set cookie
|
|
ctx.Request().Header.SetCookie(store.sessionName, unexpectedID)
|
|
|
|
acquiredSession, err := store.Get(ctx)
|
|
require.NoError(t, err)
|
|
|
|
require.NotEqual(t, unexpectedID, acquiredSession.ID())
|
|
})
|
|
}
|
|
|
|
// go test -run Test_Store_DeleteSession
|
|
func Test_Store_DeleteSession(t *testing.T) {
|
|
t.Parallel()
|
|
// fiber instance
|
|
app := fiber.New()
|
|
// session store
|
|
store := NewStore()
|
|
|
|
// fiber context
|
|
ctx := app.AcquireCtx(&fasthttp.RequestCtx{})
|
|
defer app.ReleaseCtx(ctx)
|
|
|
|
// Create a new session
|
|
session, err := store.Get(ctx)
|
|
require.NoError(t, err)
|
|
|
|
// Save the session ID
|
|
sessionID := session.ID()
|
|
|
|
// Delete the session
|
|
err = store.Delete(sessionID)
|
|
require.NoError(t, err)
|
|
|
|
// Try to get the session again
|
|
session, err = store.Get(ctx)
|
|
require.NoError(t, err)
|
|
|
|
// The session ID should be different now, because the old session was deleted
|
|
require.NotEqual(t, sessionID, session.ID())
|
|
}
|
|
|
|
func TestStore_Get_SessionAlreadyLoaded(t *testing.T) {
|
|
// Create a new Fiber app
|
|
app := fiber.New()
|
|
|
|
// Create a new context
|
|
ctx := app.AcquireCtx(&fasthttp.RequestCtx{})
|
|
defer app.ReleaseCtx(ctx)
|
|
|
|
// Mock middleware and set it in the context
|
|
middleware := &Middleware{}
|
|
ctx.Locals(middlewareContextKey, middleware)
|
|
|
|
// Create a new store
|
|
store := &Store{}
|
|
|
|
// Call the Get method
|
|
sess, err := store.Get(ctx)
|
|
|
|
// Assert that the error is ErrSessionAlreadyLoadedByMiddleware
|
|
require.Nil(t, sess)
|
|
require.Equal(t, ErrSessionAlreadyLoadedByMiddleware, err)
|
|
}
|
|
|
|
func TestStore_Delete(t *testing.T) {
|
|
// Create a new store
|
|
store := NewStore()
|
|
|
|
t.Run("delete with empty session ID", func(t *testing.T) {
|
|
err := store.Delete("")
|
|
require.Error(t, err)
|
|
require.Equal(t, ErrEmptySessionID, err)
|
|
})
|
|
|
|
t.Run("delete non-existing session", func(t *testing.T) {
|
|
err := store.Delete("non-existing-session-id")
|
|
require.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func Test_Store_GetByID(t *testing.T) {
|
|
t.Parallel()
|
|
// Create a new store
|
|
store := NewStore()
|
|
|
|
t.Run("empty session ID", func(t *testing.T) {
|
|
t.Parallel()
|
|
sess, err := store.GetByID("")
|
|
require.Error(t, err)
|
|
require.Nil(t, sess)
|
|
require.Equal(t, ErrEmptySessionID, err)
|
|
})
|
|
|
|
t.Run("non-existent session ID", func(t *testing.T) {
|
|
t.Parallel()
|
|
sess, err := store.GetByID("non-existent-session-id")
|
|
require.Error(t, err)
|
|
require.Nil(t, sess)
|
|
require.Equal(t, ErrSessionIDNotFoundInStore, err)
|
|
})
|
|
|
|
t.Run("valid session ID", func(t *testing.T) {
|
|
t.Parallel()
|
|
app := fiber.New()
|
|
// Create a new session
|
|
ctx := app.AcquireCtx(&fasthttp.RequestCtx{})
|
|
session, err := store.Get(ctx)
|
|
defer session.Release()
|
|
defer app.ReleaseCtx(ctx)
|
|
require.NoError(t, err)
|
|
|
|
// Save the session ID
|
|
sessionID := session.ID()
|
|
|
|
// Save the session
|
|
err = session.Save()
|
|
require.NoError(t, err)
|
|
|
|
// Retrieve the session by ID
|
|
retrievedSession, err := store.GetByID(sessionID)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, retrievedSession)
|
|
require.Equal(t, sessionID, retrievedSession.ID())
|
|
|
|
// Call Save on the retrieved session
|
|
retrievedSession.Set("key", "value")
|
|
err = retrievedSession.Save()
|
|
require.NoError(t, err)
|
|
|
|
// Call Other Session methods
|
|
require.Equal(t, "value", retrievedSession.Get("key"))
|
|
require.False(t, retrievedSession.Fresh())
|
|
|
|
require.NoError(t, retrievedSession.Reset())
|
|
require.NoError(t, retrievedSession.Destroy())
|
|
require.IsType(t, []any{}, retrievedSession.Keys())
|
|
require.NoError(t, retrievedSession.Regenerate())
|
|
require.NotPanics(t, func() {
|
|
retrievedSession.Release()
|
|
})
|
|
})
|
|
}
|