fiber/middleware
Jason McNeil e3232c1505
feat!(middleware/session): re-write session middleware with handler (#3016)
* feat!(middleware/session): re-write session middleware with handler

* test(middleware/session): refactor to IdleTimeout

* fix: lint errors

* test: Save session after setting or deleting raw data in CSRF middleware

* Update middleware/session/middleware.go

Co-authored-by: Renan Bastos <renanbastos.tec@gmail.com>

* fix: mutex and globals order

* feat: Re-Add read lock to session Get method

* feat: Migrate New() to return middleware

* chore: Refactor session middleware to improve session handling

* chore: Private get on store

* chore: Update session middleware to use saveSession instead of save

* chore: Update session middleware to use getSession instead of get

* chore: Remove unused error handler in session middleware config

* chore: Update session middleware to use NewWithStore in CSRF tests

* test: add test

* fix: destroyed session and GHSA-98j2-3j3p-fw2v

* chore: Refactor session_test.go to use newStore() instead of New()

* feat: Improve session middleware test coverage and error handling

This commit improves the session middleware test coverage by adding assertions for the presence of the Set-Cookie header and the token value. It also enhances error handling by checking for the expected number of parts in the Set-Cookie header.

* chore: fix lint issues

* chore: Fix session middleware locking issue and improve error handling

* test: improve middleware test coverage and error handling

* test: Add idle timeout test case to session middleware test

* feat: add GetSession(id string) (*Session, error)

* chore: lint

* docs: Update session middleware docs

* docs: Security Note to examples

* docs: Add recommendation for CSRF protection in session middleware

* chore: markdown lint

* docs: Update session middleware docs

* docs: makrdown lint

* test(middleware/session): Add unit tests for session config.go

* test(middleware/session): Add unit tests for store.go

* test(middleware/session): Add data.go unit tests

* refactor(middleware/session): session tests and add session release test

- Refactor session tests to improve readability and maintainability.
- Add a new test case to ensure proper session release functionality.
- Update session.md

* refactor: session data locking in middleware/session/data.go

* refactor(middleware/session): Add unit test for session middleware store

* test: fix session_test.go and store_test.go unit tests

* refactor(docs): Update session.md with v3 changes to Expiration

* refactor(middleware/session): Improve data pool handling and locking

* chore(middleware/session): TODO for Expiration field in session config

* refactor(middleware/session): Improve session data pool handling and locking

* refactor(middleware/session): Improve session data pool handling and locking

* test(middleware/csrf): add session middleware coverage

* chroe(middleware/session): TODO for unregistered session middleware

* refactor(middleware/session): Update session middleware for v3 changes

* refactor(middleware/session): Update session middleware for v3 changes

* refactor(middleware/session): Update session middleware idle timeout

- Update the default idle timeout for session middleware from 24 hours to 30 minutes.
- Add a note in the session middleware documentation about the importance of the middleware order.

* docws(middleware/session): Add note about IdleTimeout requiring save using legacy approach

* refactor(middleware/session): Update session middleware idle timeout

Update the idle timeout for the session middleware to 30 minutes. This ensures that the session expires after a period of inactivity. The previous value was 24 hours, which is too long for most use cases. This change improves the security and efficiency of the session management.

* docs(middleware/session): Update session middleware idle timeout and configuration

* test(middleware/session): Fix tests for updated panics

* refactor(middleware/session): Update session middleware initialization and saving

* refactor(middleware/session): Remove unnecessary comment about negative IdleTimeout value

* refactor(middleware/session): Update session middleware make NewStore public

* refactor(middleware/session): Update session middleware Set, Get, and Delete methods

Refactor the Set, Get, and Delete methods in the session middleware to use more descriptive parameter names. Instead of using "middlewareContextKey", the methods now use "key" to represent the key of the session value. This improves the readability and clarity of the code.

* feat(middleware/session): AbsoluteTimeout and key any

* fix(middleware/session): locking issues and lint errors

* chore(middleware/session): Regenerate code in data_msgp.go

* refactor(middleware/session): rename GetSessionByID to GetByID

This commit also includes changes to the session_test.go and store_test.go files to add test cases for the new GetByID method.

* docs(middleware/session): AbsoluteTimeout

* refactor(middleware/csrf): Rename Expiration to IdleTimeout

* docs(whats-new): CSRF Rename Expiration to IdleTimeout and remove SessionKey field

* refactor(middleware/session): Rename expirationKeyType to absExpirationKeyType and update related functions

* refactor(middleware/session): rename Test_Session_Save_Absolute to Test_Session_Save_AbsoluteTimeout

* chore(middleware/session): update as per PR comments

* docs(middlware/session): fix indent lint

* fix(middleware/session): Address EfeCtn Comments

* refactor(middleware/session): Move bytesBuffer to it's own pool

* test(middleware/session): add decodeSessionData error coverage

* refactor(middleware/session): Update absolute timeout handling

- Update absolute timeout handling in getSession function
- Set absolute expiration time in getSession function
- Delete expired session in GetByID function

* refactor(session/middleware): fix *Session nil ctx when using Store.GetByID

* refactor(middleware/session): Remove unnecessary line in session_test.go

* fix(middleware/session): *Session lifecycle issues

* docs(middleware/session): Update GetByID method documentation

* docs(middleware/session): Update GetByID method documentation

* docs(middleware/session): markdown lint

* refactor(middleware/session): Simplify error handling in DefaultErrorHandler

* fix( middleware/session/config.go

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* add ctx releases for the test cases

---------

Co-authored-by: Renan Bastos <renanbastos.tec@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Juan Calderon-Perez <835733+gaby@users.noreply.github.com>
Co-authored-by: René <rene@gofiber.io>
2024-10-25 08:36:30 +02:00
..
adaptor 🩹Fix: Adaptor middleware duplicates cookies (#3151) 2024-10-03 16:19:27 +02:00
basicauth v3: Use Named Fields Instead of Positional and Align Structures to Reduce Memory Usage (#3079) 2024-07-23 08:37:45 +02:00
cache chore(middleware/cache): fix typo (#3145) 2024-09-25 08:44:04 +02:00
compress chore: Bump golangci-lint to v1.60.3 (#3119) 2024-09-02 15:38:59 +02:00
cors 🔥Feature: Add support for TrustProxy (#3170) 2024-10-17 08:29:03 +02:00
csrf feat!(middleware/session): re-write session middleware with handler (#3016) 2024-10-25 08:36:30 +02:00
earlydata 🔥Feature: Add support for TrustProxy (#3170) 2024-10-17 08:29:03 +02:00
encryptcookie chore: Bump golangci-lint to v1.60.3 (#3119) 2024-09-02 15:38:59 +02:00
envvar v3: Use Named Fields Instead of Positional and Align Structures to Reduce Memory Usage (#3079) 2024-07-23 08:37:45 +02:00
etag Bump golangci-lint to v1.61.0 (#3135) 2024-09-15 19:28:22 +02:00
expvar Merge remote-tracking branch 'origin/master' into v3-beta 2023-08-05 22:02:01 +03:00
favicon v3: Use Named Fields Instead of Positional and Align Structures to Reduce Memory Usage (#3079) 2024-07-23 08:37:45 +02:00
healthcheck feat: Add Startup Probe to Healthcheck Middleware (#3069) 2024-07-18 13:54:44 +02:00
helmet v3: Use Named Fields Instead of Positional and Align Structures to Reduce Memory Usage (#3079) 2024-07-23 08:37:45 +02:00
idempotency enhancement: use msgp for flash message encoding/decoding (#3099) 2024-08-29 16:45:16 +02:00
keyauth v3: Use Named Fields Instead of Positional and Align Structures to Reduce Memory Usage (#3079) 2024-07-23 08:37:45 +02:00
limiter chore: Bump golangci-lint to v1.60.3 (#3119) 2024-09-02 15:38:59 +02:00
logger v3: Use Named Fields Instead of Positional and Align Structures to Reduce Memory Usage (#3079) 2024-07-23 08:37:45 +02:00
pprof chore: Bump golangci-lint to v1.60.3 (#3119) 2024-09-02 15:38:59 +02:00
proxy v3: Use Named Fields Instead of Positional and Align Structures to Reduce Memory Usage (#3079) 2024-07-23 08:37:45 +02:00
recover v3: Use Named Fields Instead of Positional and Align Structures to Reduce Memory Usage (#3079) 2024-07-23 08:37:45 +02:00
redirect v3: Use Named Fields Instead of Positional and Align Structures to Reduce Memory Usage (#3079) 2024-07-23 08:37:45 +02:00
requestid v3: Use Named Fields Instead of Positional and Align Structures to Reduce Memory Usage (#3079) 2024-07-23 08:37:45 +02:00
rewrite v3: Add Benchmarks for Rewrite Middleware (#3092) 2024-07-26 16:55:00 +02:00
session feat!(middleware/session): re-write session middleware with handler (#3016) 2024-10-25 08:36:30 +02:00
skip Merge remote-tracking branch 'origin/master' into v3-beta 2023-08-05 22:02:01 +03:00
static chore: Bump golangci-lint to v1.60.3 (#3119) 2024-09-02 15:38:59 +02:00
timeout V2 to v3 merge (#2864) 2024-02-29 08:29:59 +01:00