mirror of
https://github.com/gofiber/fiber.git
synced 2025-05-13 03:06:11 +00:00
* feat!(middleware/session): re-write session middleware with handler * test(middleware/session): refactor to IdleTimeout * fix: lint errors * test: Save session after setting or deleting raw data in CSRF middleware * Update middleware/session/middleware.go Co-authored-by: Renan Bastos <renanbastos.tec@gmail.com> * fix: mutex and globals order * feat: Re-Add read lock to session Get method * feat: Migrate New() to return middleware * chore: Refactor session middleware to improve session handling * chore: Private get on store * chore: Update session middleware to use saveSession instead of save * chore: Update session middleware to use getSession instead of get * chore: Remove unused error handler in session middleware config * chore: Update session middleware to use NewWithStore in CSRF tests * test: add test * fix: destroyed session and GHSA-98j2-3j3p-fw2v * chore: Refactor session_test.go to use newStore() instead of New() * feat: Improve session middleware test coverage and error handling This commit improves the session middleware test coverage by adding assertions for the presence of the Set-Cookie header and the token value. It also enhances error handling by checking for the expected number of parts in the Set-Cookie header. * chore: fix lint issues * chore: Fix session middleware locking issue and improve error handling * test: improve middleware test coverage and error handling * test: Add idle timeout test case to session middleware test * feat: add GetSession(id string) (*Session, error) * chore: lint * docs: Update session middleware docs * docs: Security Note to examples * docs: Add recommendation for CSRF protection in session middleware * chore: markdown lint * docs: Update session middleware docs * docs: makrdown lint * test(middleware/session): Add unit tests for session config.go * test(middleware/session): Add unit tests for store.go * test(middleware/session): Add data.go unit tests * refactor(middleware/session): session tests and add session release test - Refactor session tests to improve readability and maintainability. - Add a new test case to ensure proper session release functionality. - Update session.md * refactor: session data locking in middleware/session/data.go * refactor(middleware/session): Add unit test for session middleware store * test: fix session_test.go and store_test.go unit tests * refactor(docs): Update session.md with v3 changes to Expiration * refactor(middleware/session): Improve data pool handling and locking * chore(middleware/session): TODO for Expiration field in session config * refactor(middleware/session): Improve session data pool handling and locking * refactor(middleware/session): Improve session data pool handling and locking * test(middleware/csrf): add session middleware coverage * chroe(middleware/session): TODO for unregistered session middleware * refactor(middleware/session): Update session middleware for v3 changes * refactor(middleware/session): Update session middleware for v3 changes * refactor(middleware/session): Update session middleware idle timeout - Update the default idle timeout for session middleware from 24 hours to 30 minutes. - Add a note in the session middleware documentation about the importance of the middleware order. * docws(middleware/session): Add note about IdleTimeout requiring save using legacy approach * refactor(middleware/session): Update session middleware idle timeout Update the idle timeout for the session middleware to 30 minutes. This ensures that the session expires after a period of inactivity. The previous value was 24 hours, which is too long for most use cases. This change improves the security and efficiency of the session management. * docs(middleware/session): Update session middleware idle timeout and configuration * test(middleware/session): Fix tests for updated panics * refactor(middleware/session): Update session middleware initialization and saving * refactor(middleware/session): Remove unnecessary comment about negative IdleTimeout value * refactor(middleware/session): Update session middleware make NewStore public * refactor(middleware/session): Update session middleware Set, Get, and Delete methods Refactor the Set, Get, and Delete methods in the session middleware to use more descriptive parameter names. Instead of using "middlewareContextKey", the methods now use "key" to represent the key of the session value. This improves the readability and clarity of the code. * feat(middleware/session): AbsoluteTimeout and key any * fix(middleware/session): locking issues and lint errors * chore(middleware/session): Regenerate code in data_msgp.go * refactor(middleware/session): rename GetSessionByID to GetByID This commit also includes changes to the session_test.go and store_test.go files to add test cases for the new GetByID method. * docs(middleware/session): AbsoluteTimeout * refactor(middleware/csrf): Rename Expiration to IdleTimeout * docs(whats-new): CSRF Rename Expiration to IdleTimeout and remove SessionKey field * refactor(middleware/session): Rename expirationKeyType to absExpirationKeyType and update related functions * refactor(middleware/session): rename Test_Session_Save_Absolute to Test_Session_Save_AbsoluteTimeout * chore(middleware/session): update as per PR comments * docs(middlware/session): fix indent lint * fix(middleware/session): Address EfeCtn Comments * refactor(middleware/session): Move bytesBuffer to it's own pool * test(middleware/session): add decodeSessionData error coverage * refactor(middleware/session): Update absolute timeout handling - Update absolute timeout handling in getSession function - Set absolute expiration time in getSession function - Delete expired session in GetByID function * refactor(session/middleware): fix *Session nil ctx when using Store.GetByID * refactor(middleware/session): Remove unnecessary line in session_test.go * fix(middleware/session): *Session lifecycle issues * docs(middleware/session): Update GetByID method documentation * docs(middleware/session): Update GetByID method documentation * docs(middleware/session): markdown lint * refactor(middleware/session): Simplify error handling in DefaultErrorHandler * fix( middleware/session/config.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add ctx releases for the test cases --------- Co-authored-by: Renan Bastos <renanbastos.tec@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan Calderon-Perez <835733+gaby@users.noreply.github.com> Co-authored-by: René <rene@gofiber.io>
189 lines
4.8 KiB
Go
189 lines
4.8 KiB
Go
package session
|
|
|
|
import (
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/gofiber/fiber/v3"
|
|
"github.com/gofiber/fiber/v3/log"
|
|
"github.com/gofiber/utils/v2"
|
|
)
|
|
|
|
// Config defines the configuration for the session middleware.
|
|
type Config struct {
|
|
// Storage interface for storing session data.
|
|
//
|
|
// Optional. Default: memory.New()
|
|
Storage fiber.Storage
|
|
|
|
// Next defines a function to skip this middleware when it returns true.
|
|
// Optional. Default: nil
|
|
Next func(c fiber.Ctx) bool
|
|
|
|
// Store defines the session store.
|
|
//
|
|
// Required.
|
|
Store *Store
|
|
|
|
// ErrorHandler defines a function to handle errors.
|
|
//
|
|
// Optional. Default: nil
|
|
ErrorHandler func(fiber.Ctx, error)
|
|
|
|
// KeyGenerator generates the session key.
|
|
//
|
|
// Optional. Default: utils.UUIDv4
|
|
KeyGenerator func() string
|
|
|
|
// KeyLookup is a string in the format "<source>:<name>" used to extract the session ID from the request.
|
|
//
|
|
// Possible values: "header:<name>", "query:<name>", "cookie:<name>"
|
|
//
|
|
// Optional. Default: "cookie:session_id"
|
|
KeyLookup string
|
|
|
|
// CookieDomain defines the domain of the session cookie.
|
|
//
|
|
// Optional. Default: ""
|
|
CookieDomain string
|
|
|
|
// CookiePath defines the path of the session cookie.
|
|
//
|
|
// Optional. Default: ""
|
|
CookiePath string
|
|
|
|
// CookieSameSite specifies the SameSite attribute of the cookie.
|
|
//
|
|
// Optional. Default: "Lax"
|
|
CookieSameSite string
|
|
|
|
// Source defines where to obtain the session ID.
|
|
source Source
|
|
|
|
// sessionName is the name of the session.
|
|
sessionName string
|
|
|
|
// IdleTimeout defines the maximum duration of inactivity before the session expires.
|
|
//
|
|
// Note: The idle timeout is updated on each `Save()` call. If a middleware handler is used, `Save()` is called automatically.
|
|
//
|
|
// Optional. Default: 30 * time.Minute
|
|
IdleTimeout time.Duration
|
|
|
|
// AbsoluteTimeout defines the maximum duration of the session before it expires.
|
|
//
|
|
// If set to 0, the session will not have an absolute timeout, and will expire after the idle timeout.
|
|
//
|
|
// Optional. Default: 0
|
|
AbsoluteTimeout time.Duration
|
|
|
|
// CookieSecure specifies if the session cookie should be secure.
|
|
//
|
|
// Optional. Default: false
|
|
CookieSecure bool
|
|
|
|
// CookieHTTPOnly specifies if the session cookie should be HTTP-only.
|
|
//
|
|
// Optional. Default: false
|
|
CookieHTTPOnly bool
|
|
|
|
// CookieSessionOnly determines if the cookie should expire when the browser session ends.
|
|
//
|
|
// If true, the cookie will be deleted when the browser is closed.
|
|
// Note: This will not delete the session data from the store.
|
|
//
|
|
// Optional. Default: false
|
|
CookieSessionOnly bool
|
|
}
|
|
|
|
// Source represents the type of session ID source.
|
|
type Source string
|
|
|
|
const (
|
|
SourceCookie Source = "cookie"
|
|
SourceHeader Source = "header"
|
|
SourceURLQuery Source = "query"
|
|
)
|
|
|
|
// ConfigDefault provides the default configuration.
|
|
var ConfigDefault = Config{
|
|
IdleTimeout: 30 * time.Minute,
|
|
KeyLookup: "cookie:session_id",
|
|
KeyGenerator: utils.UUIDv4,
|
|
source: SourceCookie,
|
|
sessionName: "session_id",
|
|
}
|
|
|
|
// DefaultErrorHandler logs the error and sends a 500 status code.
|
|
//
|
|
// Parameters:
|
|
// - c: The Fiber context.
|
|
// - err: The error to handle.
|
|
//
|
|
// Usage:
|
|
//
|
|
// DefaultErrorHandler(c, err)
|
|
func DefaultErrorHandler(c fiber.Ctx, err error) {
|
|
log.Errorf("session: %v", err)
|
|
if sendErr := c.SendStatus(fiber.StatusInternalServerError); sendErr != nil {
|
|
log.Errorf("session: %v", sendErr)
|
|
}
|
|
}
|
|
|
|
// configDefault sets default values for the Config struct.
|
|
//
|
|
// Parameters:
|
|
// - config: Variadic parameter to override the default config.
|
|
//
|
|
// Returns:
|
|
// - Config: The configuration with default values set.
|
|
//
|
|
// Usage:
|
|
//
|
|
// cfg := configDefault()
|
|
// cfg := configDefault(customConfig)
|
|
func configDefault(config ...Config) Config {
|
|
// Return default config if none provided.
|
|
if len(config) < 1 {
|
|
return ConfigDefault
|
|
}
|
|
|
|
// Override default config with provided config.
|
|
cfg := config[0]
|
|
|
|
// Set default values where necessary.
|
|
if cfg.IdleTimeout <= 0 {
|
|
cfg.IdleTimeout = ConfigDefault.IdleTimeout
|
|
}
|
|
// Ensure AbsoluteTimeout is greater than or equal to IdleTimeout.
|
|
if cfg.AbsoluteTimeout > 0 && cfg.AbsoluteTimeout < cfg.IdleTimeout {
|
|
panic("[session] AbsoluteTimeout must be greater than or equal to IdleTimeout")
|
|
}
|
|
if cfg.KeyLookup == "" {
|
|
cfg.KeyLookup = ConfigDefault.KeyLookup
|
|
}
|
|
if cfg.KeyGenerator == nil {
|
|
cfg.KeyGenerator = ConfigDefault.KeyGenerator
|
|
}
|
|
|
|
// Parse KeyLookup into source and session name.
|
|
selectors := strings.Split(cfg.KeyLookup, ":")
|
|
const numSelectors = 2
|
|
if len(selectors) != numSelectors {
|
|
panic("[session] KeyLookup must be in the format '<source>:<name>'")
|
|
}
|
|
switch Source(selectors[0]) {
|
|
case SourceCookie:
|
|
cfg.source = SourceCookie
|
|
case SourceHeader:
|
|
cfg.source = SourceHeader
|
|
case SourceURLQuery:
|
|
cfg.source = SourceURLQuery
|
|
default:
|
|
panic("[session] unsupported source in KeyLookup")
|
|
}
|
|
cfg.sessionName = selectors[1]
|
|
|
|
return cfg
|
|
}
|