From fc115621912b5ebc2af4bfbc113e9842556532ed Mon Sep 17 00:00:00 2001 From: Tom Date: Thu, 8 Oct 2020 21:12:27 +0100 Subject: [PATCH] =?UTF-8?q?=E2=9C=85=20Fix=20gosec=20and=20tests?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- middleware/limiter/limiter.go | 5 ++++- middleware/limiter/limiter_test.go | 6 ++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/middleware/limiter/limiter.go b/middleware/limiter/limiter.go index 1c1f678c..bbb6991e 100644 --- a/middleware/limiter/limiter.go +++ b/middleware/limiter/limiter.go @@ -191,7 +191,10 @@ func New(config ...Config) fiber.Handler { } // Store those bytes - cfg.Store.Set(key, buf.Bytes(), time.Duration(0)) + err = cfg.Store.Set(key, buf.Bytes(), time.Duration(0)) + if err != nil { + return err + } } else { sessions[key] = session } diff --git a/middleware/limiter/limiter_test.go b/middleware/limiter/limiter_test.go index c8a8edb2..336c1392 100644 --- a/middleware/limiter/limiter_test.go +++ b/middleware/limiter/limiter_test.go @@ -119,8 +119,10 @@ func Test_Limiter_Headers(t *testing.T) { app.Handler()(fctx) utils.AssertEqual(t, "50", string(fctx.Response.Header.Peek("X-RateLimit-Limit"))) - utils.AssertEqual(t, "48", string(fctx.Response.Header.Peek("X-RateLimit-Remaining"))) + if v := string(fctx.Response.Header.Peek("X-RateLimit-Reset")); v != "" { + t.Errorf("The X-RateLimit-Remaining header is not set correctly - value is an empty string.") + } if v := string(fctx.Response.Header.Peek("X-RateLimit-Reset")); !(v == "1" || v == "2") { - t.Errorf("The X-RateLimit-Reset header is not set correctly - value is an empty string.") + t.Errorf("The X-RateLimit-Reset header is not set correctly - value is out of bounds.") } }