GOMODULES/fiber
1
0
Fork 0
mirror of https://github.com/gofiber/fiber.git synced 2025-05-31 11:52:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

🧹 chore: Mark unused tests with t.SkipNow (#3366)

Browse Source 
* 🚨 test: uncomment test and mark it with t.SkipNow

* fix lint issues
This commit is contained in:
Oleksandr Redko 2025-03-20 06:35:59 -07:00 committed by GitHub
parent 87f3f0c8b6
commit f6ac929fde
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 50 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

91
middleware/csrf/csrf_test.go
View File

@ -1331,56 +1331,65 @@ func Test_CSRF_Cookie_Injection_Exploit(t *testing.T) {
} }
// TODO: use this test case and make the unsafe header value bug from https://github.com/gofiber/fiber/issues/2045 reproducible and permanently fixed/tested by this testcase // TODO: use this test case and make the unsafe header value bug from https://github.com/gofiber/fiber/issues/2045 reproducible and permanently fixed/tested by this testcase
// func Test_CSRF_UnsafeHeaderValue(t *testing.T) { func Test_CSRF_UnsafeHeaderValue(t *testing.T) {
// t.Parallel() t.SkipNow()
// app := fiber.New() t.Parallel()
app := fiber.New()
// app.Use(New()) app.Use(New())
// app.Get("/", func(c fiber.Ctx) error { app.Get("/", func(c fiber.Ctx) error {
// return c.SendStatus(fiber.StatusOK) return c.SendStatus(fiber.StatusOK)
// }) })
// app.Get("/test", func(c fiber.Ctx) error { app.Get("/test", func(c fiber.Ctx) error {
// return c.SendStatus(fiber.StatusOK) return c.SendStatus(fiber.StatusOK)
// }) })
// app.Post("/", func(c fiber.Ctx) error { app.Post("/", func(c fiber.Ctx) error {
// return c.SendStatus(fiber.StatusOK) return c.SendStatus(fiber.StatusOK)
// }) })
// resp, err := app.Test(httptest.NewRequest(fiber.MethodGet, "/", nil)) resp, err := app.Test(httptest.NewRequest(fiber.MethodGet, "/", nil))
// require.NoError(t, err) require.NoError(t, err)
// require.Equal(t, fiber.StatusOK, resp.StatusCode) require.Equal(t, fiber.StatusOK, resp.StatusCode)
// var token string var token string
// for _, c := range resp.Cookies() { for _, c := range resp.Cookies() {
// if c.Name != ConfigDefault.CookieName { if c.Name != ConfigDefault.CookieName {
// continue continue
// } }
// token = c.Value token = c.Value
// break break
// } }
// fmt.Println("token", token) t.Log("token", token)
// getReq := httptest.NewRequest(fiber.MethodGet, "/", nil) getReq := httptest.NewRequest(fiber.MethodGet, "/", nil)
// getReq.Header.Set(HeaderName, token) getReq.Header.Set(HeaderName, token)
// resp, err = app.Test(getReq) resp, err = app.Test(getReq)
require.NoError(t, err)
require.Equal(t, fiber.StatusOK, resp.StatusCode)
// getReq = httptest.NewRequest(fiber.MethodGet, "/test", nil) getReq = httptest.NewRequest(fiber.MethodGet, "/test", nil)
// getReq.Header.Set("X-Requested-With", "XMLHttpRequest") getReq.Header.Set("X-Requested-With", "XMLHttpRequest")
// getReq.Header.Set(fiber.HeaderCacheControl, "no") getReq.Header.Set(fiber.HeaderCacheControl, "no")
// getReq.Header.Set(HeaderName, token) getReq.Header.Set(HeaderName, token)
// resp, err = app.Test(getReq) resp, err = app.Test(getReq)
require.NoError(t, err)
require.Equal(t, fiber.StatusOK, resp.StatusCode)
// getReq.Header.Set(fiber.HeaderAccept, "*/*") getReq.Header.Set(fiber.HeaderAccept, "*/*")
// getReq.Header.Del(HeaderName) getReq.Header.Del(HeaderName)
// resp, err = app.Test(getReq) resp, err = app.Test(getReq)
require.NoError(t, err)
require.Equal(t, fiber.StatusOK, resp.StatusCode)
// postReq := httptest.NewRequest(fiber.MethodPost, "/", nil) postReq := httptest.NewRequest(fiber.MethodPost, "/", nil)
// postReq.Header.Set("X-Requested-With", "XMLHttpRequest") postReq.Header.Set("X-Requested-With", "XMLHttpRequest")
// postReq.Header.Set(HeaderName, token) postReq.Header.Set(HeaderName, token)
// resp, err = app.Test(postReq) resp, err = app.Test(postReq)
// } require.NoError(t, err)
require.Equal(t, fiber.StatusOK, resp.StatusCode)
}
// go test -v -run=^$ -bench=Benchmark_Middleware_CSRF_Check -benchmem -count=4 // go test -v -run=^$ -bench=Benchmark_Middleware_CSRF_Check -benchmem -count=4
func Benchmark_Middleware_CSRF_Check(b *testing.B) { func Benchmark_Middleware_CSRF_Check(b *testing.B) {