From ef073601e3c229fcdbc6d70ffd5bc57bea33b0b5 Mon Sep 17 00:00:00 2001 From: RW Date: Mon, 22 Jul 2024 14:36:21 +0200 Subject: [PATCH] Update benchmark.yml We should only fail during a PR, not during a merge --- .github/workflows/benchmark.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 089de2ec..c1792828 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -77,7 +77,7 @@ jobs: external-data-json-path: ./cache/benchmark-data.json # Save the data to external file (cache) save-data-file: true - fail-on-alert: true + fail-on-alert: false github-token: ${{ secrets.GITHUB_TOKEN }} summary-always: true alert-threshold: "150%" @@ -89,7 +89,7 @@ jobs: tool: 'go' output-file-path: output.txt benchmark-data-dir-path: "benchmarks" - fail-on-alert: true + fail-on-alert: false github-token: ${{ secrets.GITHUB_TOKEN }} comment-on-alert: true summary-always: true @@ -105,4 +105,4 @@ jobs: if: ${{ github.ref_name == 'main' }} with: path: ./cache - key: ${{ steps.get-main-branch-sha.outputs.sha }}-${{ runner.os }}-${{ steps.system-info.outputs.cpu-model }}-benchmark \ No newline at end of file + key: ${{ steps.get-main-branch-sha.outputs.sha }}-${{ runner.os }}-${{ steps.system-info.outputs.cpu-model }}-benchmark