From c8b1879b11d4f09fbba3fef9f741f9bc2f28db64 Mon Sep 17 00:00:00 2001 From: Amir Hossein <77993374+Kamandlou@users.noreply.github.com> Date: Mon, 5 Sep 2022 15:41:09 +0430 Subject: [PATCH] fix unhandled errors in app_test.go (#2071) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix unhandled errors * fix unhandled error in cache package test * omit variable type * omit variable type * rename variable because collide with the imported package name * handle file error on closing * fix unhandled in common_linux.go * fix unhandled errors in helpers_test.go * fix unhandled errors in listen_test.go * remove unused parameter in emptyHandler method * refactor path.go * unhandled error in hooks test * fix unhandled errors in app_test.go * fix unhandled errors in ctx_test.go * ✨ fix unhandled errors in helpers_test.go * revert app_test.go --- app_test.go | 3 ++- ctx_test.go | 27 +++++++++++++++++---------- helpers_test.go | 9 ++++++--- 3 files changed, 25 insertions(+), 14 deletions(-) diff --git a/app_test.go b/app_test.go index fcb623bd..d186193a 100644 --- a/app_test.go +++ b/app_test.go @@ -1378,7 +1378,8 @@ func Test_App_New_Test_Parallel(t *testing.T) { t.Run("Test_App_New_Test_Parallel_2", func(t *testing.T) { t.Parallel() app := New(Config{Immutable: true}) - app.Test(httptest.NewRequest("GET", "/", nil)) + _, err := app.Test(httptest.NewRequest("GET", "/", nil)) + utils.AssertEqual(t, nil, err) }) } diff --git a/ctx_test.go b/ctx_test.go index 31f47e7a..caf03787 100644 --- a/ctx_test.go +++ b/ctx_test.go @@ -755,35 +755,42 @@ func Test_Ctx_Format(t *testing.T) { c := app.AcquireCtx(&fasthttp.RequestCtx{}) defer app.ReleaseCtx(c) c.Request().Header.Set(HeaderAccept, MIMETextPlain) - c.Format([]byte("Hello, World!")) + err := c.Format([]byte("Hello, World!")) + utils.AssertEqual(t, nil, err) utils.AssertEqual(t, "Hello, World!", string(c.Response().Body())) c.Request().Header.Set(HeaderAccept, MIMETextHTML) - c.Format("Hello, World!") + err = c.Format("Hello, World!") + utils.AssertEqual(t, nil, err) utils.AssertEqual(t, "

Hello, World!

", string(c.Response().Body())) c.Request().Header.Set(HeaderAccept, MIMEApplicationJSON) - c.Format("Hello, World!") + err = c.Format("Hello, World!") + utils.AssertEqual(t, nil, err) utils.AssertEqual(t, `"Hello, World!"`, string(c.Response().Body())) c.Request().Header.Set(HeaderAccept, MIMETextPlain) - c.Format(complex(1, 1)) + err = c.Format(complex(1, 1)) + utils.AssertEqual(t, nil, err) utils.AssertEqual(t, "(1+1i)", string(c.Response().Body())) c.Request().Header.Set(HeaderAccept, MIMEApplicationXML) - c.Format("Hello, World!") + err = c.Format("Hello, World!") + utils.AssertEqual(t, nil, err) utils.AssertEqual(t, `Hello, World!`, string(c.Response().Body())) - err := c.Format(complex(1, 1)) + err = c.Format(complex(1, 1)) utils.AssertEqual(t, true, err != nil) c.Request().Header.Set(HeaderAccept, MIMETextPlain) - c.Format(Map{}) + err = c.Format(Map{}) + utils.AssertEqual(t, nil, err) utils.AssertEqual(t, "map[]", string(c.Response().Body())) type broken string c.Request().Header.Set(HeaderAccept, "broken/accept") - c.Format(broken("Hello, World!")) + err = c.Format(broken("Hello, World!")) + utils.AssertEqual(t, nil, err) utils.AssertEqual(t, `Hello, World!`, string(c.Response().Body())) } @@ -3137,8 +3144,8 @@ func Test_Ctx_Get_Location_From_Route_name(t *testing.T) { utils.AssertEqual(t, nil, err) utils.AssertEqual(t, "/user/fiber", location) }) - - t.Run("case sensitive",func(t *testing.T) { + + t.Run("case sensitive", func(t *testing.T) { app := New(Config{CaseSensitive: true}) c := app.AcquireCtx(&fasthttp.RequestCtx{}) defer app.ReleaseCtx(c) diff --git a/helpers_test.go b/helpers_test.go index e72e7272..03c1e687 100644 --- a/helpers_test.go +++ b/helpers_test.go @@ -84,7 +84,8 @@ func Test_Utils_ETag_Weak(t *testing.T) { t.Run("Match Weak ETag", func(t *testing.T) { c := app.AcquireCtx(&fasthttp.RequestCtx{}) defer app.ReleaseCtx(c) - c.SendString("Hello, World!") + err := c.SendString("Hello, World!") + utils.AssertEqual(t, nil, err) c.Request().Header.Set(HeaderIfNoneMatch, `W/"13-1831710635"`) setETag(c, true) utils.AssertEqual(t, 304, c.Response().StatusCode()) @@ -95,7 +96,8 @@ func Test_Utils_ETag_Weak(t *testing.T) { t.Run("Not Match Weak ETag", func(t *testing.T) { c := app.AcquireCtx(&fasthttp.RequestCtx{}) defer app.ReleaseCtx(c) - c.SendString("Hello, World!") + err := c.SendString("Hello, World!") + utils.AssertEqual(t, nil, err) c.Request().Header.Set(HeaderIfNoneMatch, `W/"13-1831710635xx"`) setETag(c, true) utils.AssertEqual(t, `W/"13-1831710635"`, string(c.Response().Header.Peek(HeaderETag))) @@ -135,7 +137,8 @@ func Benchmark_Utils_ETag_Weak(b *testing.B) { app := New() c := app.AcquireCtx(&fasthttp.RequestCtx{}) defer app.ReleaseCtx(c) - c.SendString("Hello, World!") + err := c.SendString("Hello, World!") + utils.AssertEqual(b, nil, err) for n := 0; n < b.N; n++ { setETag(c, true) }