From b86f79eca4325c90aded51ec220e8e551420491d Mon Sep 17 00:00:00 2001 From: Amir Hossein <77993374+Kamandlou@users.noreply.github.com> Date: Fri, 26 Aug 2022 18:16:45 +0430 Subject: [PATCH] handle file error on closing (#2050) * fix unhandled errors * fix unhandled error in cache package test * omit variable type * omit variable type * rename variable because collide with the imported package name * handle file error on closing --- internal/gopsutil/common/common.go | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/internal/gopsutil/common/common.go b/internal/gopsutil/common/common.go index dc7a927b..5c7adace 100644 --- a/internal/gopsutil/common/common.go +++ b/internal/gopsutil/common/common.go @@ -13,6 +13,7 @@ import ( "errors" "fmt" "io/ioutil" + "log" "net/url" "os" "os/exec" @@ -122,7 +123,12 @@ func ReadLinesOffsetN(filename string, offset uint, n int) ([]string, error) { if err != nil { return []string{""}, err } - defer f.Close() + defer func(f *os.File) { + err := f.Close() + if err != nil { + log.Fatalln(err) + } + }(f) var ret []string @@ -204,7 +210,12 @@ func ReadInts(filename string) ([]int64, error) { if err != nil { return []int64{}, err } - defer f.Close() + defer func(f *os.File) { + err := f.Close() + if err != nil { + log.Fatalln(err) + } + }(f) var ret []int64