GOMODULES
/
fiber
mirror of https://github.com/gofiber/fiber.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #671 from kiyonlin/fix-ctx-ips 

🩹 when X-Forwarded-For is empty, ctx.Ips() should be empty
pull/675/head
fenny 2020-07-24 17:28:26 +02:00 committed by GitHub
parent fa6b8ea659 4ebd887faa
commit 415a6026c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ctx.go
View File

@ -502,6 +502,9 @@ func (ctx *Ctx) IP() string {
// IPs returns an string slice of IP addresses specified in the X-Forwarded-For request header.
func (ctx *Ctx) IPs() (ips []string) {
header := ctx.Fasthttp.Request.Header.Peek(HeaderXForwardedFor)
if len(header) == 0 {
return
}
ips = make([]string, bytes.Count(header, []byte(","))+1)
var commaPos, i int
for {

3
ctx_test.go
View File

@ -706,6 +706,9 @@ func Test_Ctx_IPs(t *testing.T) {
defer app.ReleaseCtx(ctx)
ctx.Fasthttp.Request.Header.Set(HeaderXForwardedFor, "127.0.0.1, 127.0.0.1, 127.0.0.1")
utils.AssertEqual(t, []string{"127.0.0.1", "127.0.0.1", "127.0.0.1"}, ctx.IPs())
ctx.Fasthttp.Request.Header.Set(HeaderXForwardedFor, "")
utils.AssertEqual(t, 0, len(ctx.IPs()))
}
// go test -v -run=^$ -bench=Benchmark_Ctx_IPs -benchmem -count=4