From 17dfcc756ba4bb8b492f4916a7da2a666dc97f5a Mon Sep 17 00:00:00 2001 From: leonklingele Date: Thu, 1 Dec 2022 09:11:14 +0100 Subject: [PATCH] middleware/requestid: mention that the default UUID generator exposes the number of requests made to the server (#2241) --- middleware/requestid/README.md | 10 ++++++---- middleware/requestid/config.go | 3 +++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/middleware/requestid/README.md b/middleware/requestid/README.md index 91019d95..ffba0662 100644 --- a/middleware/requestid/README.md +++ b/middleware/requestid/README.md @@ -64,13 +64,15 @@ type Config struct { ``` ### Default Config +The default config uses a fast UUID generator which will expose the number of +requests made to the server. To conceal this value for better privacy, use the +`utils.UUIDv4` generator. + ```go var ConfigDefault = Config{ Next: nil, Header: fiber.HeaderXRequestID, - Generator: func() string { - return utils.UUID() - }, - ContextKey: "requestid" + Generator: utils.UUID, + ContextKey: "requestid", } ``` diff --git a/middleware/requestid/config.go b/middleware/requestid/config.go index ace51ad4..b3b605e5 100644 --- a/middleware/requestid/config.go +++ b/middleware/requestid/config.go @@ -30,6 +30,9 @@ type Config struct { } // ConfigDefault is the default config +// It uses a fast UUID generator which will expose the number of +// requests made to the server. To conceal this value for better +// privacy, use the "utils.UUIDv4" generator. var ConfigDefault = Config{ Next: nil, Header: fiber.HeaderXRequestID,