From d04dc0c2d0a501eb890071bcf2c415f032696189 Mon Sep 17 00:00:00 2001 From: Benjamin Wang Date: Tue, 27 Dec 2022 14:49:58 +0800 Subject: [PATCH 1/3] Support running workflow on Windows-latest Signed-off-by: Benjamin Wang --- .github/workflows/tests.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index b328c63..c2b79aa 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -2,7 +2,10 @@ name: Tests on: [push, pull_request] jobs: test: - runs-on: ubuntu-latest + strategy: + matrix: + os: [ubuntu-latest, windows-latest] + runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v3 - uses: actions/setup-go@v3 @@ -12,4 +15,4 @@ jobs: - run: make race - run: make test - name: golangci-lint - uses: golangci/golangci-lint-action@v3 + uses: golangci/golangci-lint-action@0ad9a0988b3973e851ab0a07adf248ec2e100376 # v3.3.1 From 99fe21f5e053a0525bf36290cf25510146ce4c14 Mon Sep 17 00:00:00 2001 From: Benjamin Wang Date: Tue, 27 Dec 2022 14:51:10 +0800 Subject: [PATCH 2/3] Disabled linter on field 'dataref' Signed-off-by: Benjamin Wang --- db.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/db.go b/db.go index 9b2f9d1..328b2ce 100644 --- a/db.go +++ b/db.go @@ -129,6 +129,9 @@ type DB struct { path string openFile func(string, int, os.FileMode) (*os.File, error) file *os.File + // `dataref` isn't used at all on Windows, and the golangci-lint + // always fails on Windows platform. + //nolint dataref []byte // mmap'ed readonly, write throws SEGV data *[maxMapSize]byte datasz int From 7cc5901171571d126a7284a1f966ebd12d091df2 Mon Sep 17 00:00:00 2001 From: Benjamin Wang Date: Tue, 27 Dec 2022 14:51:47 +0800 Subject: [PATCH 3/3] Extended the test timeout to 30m Signed-off-by: Benjamin Wang --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 40147e5..67e3390 100644 --- a/Makefile +++ b/Makefile @@ -14,12 +14,12 @@ lint: golangci-lint run ./... test: - TEST_FREELIST_TYPE=hashmap go test -timeout 20m -v -coverprofile cover.out -covermode atomic + TEST_FREELIST_TYPE=hashmap go test -timeout 30m -v -coverprofile cover.out -covermode atomic TEST_FREELIST_TYPE=hashmap go test -v ./cmd/bbolt @echo "array freelist test" - @TEST_FREELIST_TYPE=array go test -timeout 20m -v -coverprofile cover.out -covermode atomic + @TEST_FREELIST_TYPE=array go test -timeout 30m -v -coverprofile cover.out -covermode atomic @TEST_FREELIST_TYPE=array go test -v ./cmd/bbolt .PHONY: race fmt test lint