From 4e98e8fb3ced270408753fca9b75645e4e05f801 Mon Sep 17 00:00:00 2001 From: Wei Fu Date: Tue, 3 Jan 2023 15:42:51 +0800 Subject: [PATCH] TestDB_Concurrent_WriteTo: copy option to fix data race MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test log: ================== WARNING: DATA RACE Write at 0x00c000388370 by goroutine 37: go.etcd.io/bbolt/internal/btesting.MustOpenDBWithOption() /home/runner/work/bbolt/bbolt/internal/btesting/btesting.go:52 +0x1c7 go.etcd.io/bbolt_test.TestDB_Concurrent_WriteTo.func1() /home/runner/work/bbolt/bbolt/db_test.go:685 +0x1f4 go.etcd.io/bbolt_test.TestDB_Concurrent_WriteTo·dwrap·18() /home/runner/work/bbolt/bbolt/db_test.go:714 +0x47 Previous write at 0x00c000388370 by goroutine 83: go.etcd.io/bbolt/internal/btesting.MustOpenDBWithOption() /home/runner/work/bbolt/bbolt/internal/btesting/btesting.go:52 +0x1c7 go.etcd.io/bbolt_test.TestDB_Concurrent_WriteTo.func1() /home/runner/work/bbolt/bbolt/db_test.go:685 +0x1f4 go.etcd.io/bbolt_test.TestDB_Concurrent_WriteTo·dwrap·18() /home/runner/work/bbolt/bbolt/db_test.go:714 +0x47 Goroutine 37 (running) created at: go.etcd.io/bbolt_test.TestDB_Concurrent_WriteTo() /home/runner/work/bbolt/bbolt/db_test.go:714 +0x724 testing.tRunner() /opt/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1259 +0x22f testing.(*T).Run·dwrap·21() /opt/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1306 +0x47 Goroutine 83 (running) created at: go.etcd.io/bbolt_test.TestDB_Concurrent_WriteTo() /home/runner/work/bbolt/bbolt/db_test.go:714 +0x724 testing.tRunner() /opt/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1259 +0x22f testing.(*T).Run·dwrap·21() /opt/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1306 +0x47 ================== Signed-off-by: Wei Fu --- db_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/db_test.go b/db_test.go index 65b44c8..fa8fd69 100644 --- a/db_test.go +++ b/db_test.go @@ -682,7 +682,9 @@ func TestDB_Concurrent_WriteTo(t *testing.T) { panic(err) } f.Close() - snap := btesting.MustOpenDBWithOption(t, f.Name(), o) + + copyOpt := *o + snap := btesting.MustOpenDBWithOption(t, f.Name(), ©Opt) defer snap.MustClose() snap.MustCheck() }